comment
mbraun via llvm-commits
llvm-commits at lists.llvm.org
Tue May 1 09:30:19 PDT 2018
The two comments sound equivalent to me.
> On May 1, 2018, at 5:22 AM, Jonas Paulsson via llvm-commits <llvm-commits at lists.llvm.org> wrote:
>
> Hi,
>
> I find the comment in TargetFrameLoweringImpl.cpp slightly confusing.
>
> My interpretation here is that generally IPRA reduces save/restore in callee whenever it can, and instead does this in caller. "Callee saved registers" is however also a set of specific registers, which makes me think of concerns about the allocation order.
>
> Am I understanding things correctly, and if so does this comment change look good?
>
> - // When interprocedural register allocation is enabled caller saved registers
> - // are preferred over callee saved registers.
> + // When interprocedural register allocation is enabled it is preferred
> + // to save/restore registers in caller instead of callee.
> if (MF.getTarget().Options.EnableIPRA && isSafeForNoCSROpt(MF.getFunction()))
> return;
>
> /Jonas
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
More information about the llvm-commits
mailing list