[PATCH] D46311: [AArch64] added FP16 vcvth intrinsic support

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 1 08:43:00 PDT 2018


SjoerdMeijer added inline comments.


================
Comment at: test/CodeGen/AArch64/fp16_intrinsic_scalar_2op.ll:156
+entry:
+  %vcvth_n_f16_s32 = tail call half @llvm.aarch64.neon.vcvtfxs2fp.f16.i32(i32 %a, i32 1)
+  ret half %vcvth_n_f16_s32
----------------
What is the supported range of constant 'n' for this intrinsic? If it is e.g. [1,16], I think it is best to test the minimum value 1, which is what we do here, but also the maximum value 16.
Same comment for the other intrinsics here.


Repository:
  rL LLVM

https://reviews.llvm.org/D46311





More information about the llvm-commits mailing list