[PATCH] D45731: [InstCombine] Adjusting bswap pattern matching to hold for And/Shift mixed case

Tue May 1 05:40:59 PDT 2018

kparzysz added a comment.

In https://reviews.llvm.org/D45731#1081206, @spatel wrote:

> I haven't seen anything. For reference, I mentioned ctpop/ctlz in the context of https://reviews.llvm.org/D45986 too, so I think we should do something to organize these optimizations, but I'm not sure what's best.
>  That said, I think this patch is fine as an enhancement of the existing code, so LGTM.

Sorry, I was away last week.  My understanding is that the distinction between the regular and the aggressive instcombine is based on how expensive the individual transformations are.  If we had an infinite computational power, everything would be included in the regular instcombine.  Based on that, I think that this patch is ok as is.

Repository:
  rL LLVM

https://reviews.llvm.org/D45731