[llvm] r331255 - [MC] Add llvm_unreachable to toString to fix compile time warning.

Florian Hahn via llvm-commits llvm-commits at lists.llvm.org
Tue May 1 04:18:31 PDT 2018


Author: fhahn
Date: Tue May  1 04:18:31 2018
New Revision: 331255

URL: http://llvm.org/viewvc/llvm-project?rev=331255&view=rev
Log:
[MC] Add llvm_unreachable to toString to fix compile time warning.

Without this change, GCC 7 raises the warning below:
        control reaches end of non-void function

Reviewers: sbc100, andreadb

Reviewed By: andreadb

Differential Revision: https://reviews.llvm.org/D46304

Modified:
    llvm/trunk/lib/MC/WasmObjectWriter.cpp

Modified: llvm/trunk/lib/MC/WasmObjectWriter.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/MC/WasmObjectWriter.cpp?rev=331255&r1=331254&r2=331255&view=diff
==============================================================================
--- llvm/trunk/lib/MC/WasmObjectWriter.cpp (original)
+++ llvm/trunk/lib/MC/WasmObjectWriter.cpp Tue May  1 04:18:31 2018
@@ -47,9 +47,8 @@ static std::string toString(wasm::WasmSy
     return "WASM_SYMBOL_TYPE_DATA";
   case wasm::WASM_SYMBOL_TYPE_SECTION:
     return "WASM_SYMBOL_TYPE_SECTION";
-  default:
-    llvm_unreachable("unexpected kind");
   }
+  llvm_unreachable("unknown symbol type");
 }
 
 static std::string relocTypetoString(uint32_t type) {




More information about the llvm-commits mailing list