[PATCH] D46304: [MC] Add llvm_unreachable to toString to fix compile time warning.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 1 03:47:42 PDT 2018


fhahn added a subscriber: GBuella.
fhahn added a comment.



In https://reviews.llvm.org/D46304#1083822, @andreadb wrote:

> I just saw that Gabor fixed it at revision 331251 adding a 'default' case.
>  http://llvm.org/viewvc/llvm-project?view=revision&revision=331251


Ah thanks for pointing me to that :) @GBuella I think one minor drawback of adding a default cast is that we won't get compiler warning for missing cases, but then when WasmSymbolType is not an enum class, you probably won't get them anyways.


https://reviews.llvm.org/D46304





More information about the llvm-commits mailing list