[PATCH] D46273: [InstCombine, ARM] Convert vld1 to llvm load
Javed Absar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 30 14:47:57 PDT 2018
javed.absar added inline comments.
================
Comment at: lib/Transforms/InstCombine/InstCombineCalls.cpp:935
+ InstCombiner::BuilderTy &Builder) {
+ auto IntrAlign = dyn_cast<ConstantInt>(II.getArgOperand(1));
+ unsigned Alignment = IntrAlign && IntrAlign->getZExtValue() < MemAlign ?
----------------
There is a check of IntrAlign, but then IntrAlign is still used otherwise? Maybe it will be cleaner to not use 'auto'
================
Comment at: lib/Transforms/InstCombine/InstCombineCalls.cpp:2987
+ case Intrinsic::arm_neon_vld1: {
+ unsigned MemAlign = getKnownAlignment(II->getArgOperand(0),
+ DL, II, &AC, &DT);
----------------
It might be cleaner to extract MemAlign in the called function
https://reviews.llvm.org/D46273
More information about the llvm-commits
mailing list