[PATCH] D46254: [LV] Use BB::instructionsWithoutDebug to skip DbgInfo (NFC).

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 30 14:38:16 PDT 2018


fhahn added a comment.

In https://reviews.llvm.org/D46254#1083185, @hsaito wrote:

> Thanks, Florian. This is loosely related to https://reviews.llvm.org/D46199. See comments there. We need to consciously try using (or even creating) generically reusable code like this, instead of each file having it's own "skip this, skip that".


That was the intention behind adding BB::instructionsWithoutDebug. It should be applicable to a wide range of cases and I will try to move existing code slowly towards using it. I think there might be a case for having a generic utility function that skips lifetime/assume intrinisics. But at least the few passes I had a look at so far seemed to have problems dealing with those intrinsics in the first place.


Repository:
  rL LLVM

https://reviews.llvm.org/D46254





More information about the llvm-commits mailing list