[PATCH] D46238: [llvm-rc] Add rudimentary support for codepages

[Adrian McCarthy via Phabricator via llvm-commits]

amccarth added a comment.

Looks good to me now, but I'm not an official reviewer.

It would be nice if the CP-1252 test exercised one of the unusual characters that you had to build the map for.  Since the sources for the tests are stored as binary files, I'm having a hard time peeking into it from Phabricator, so maybe you did, but it's not obvious.


https://reviews.llvm.org/D46238