[PATCH] D38862: Add must alias info to ModRefInfo.

[Alina Sbirlea via Phabricator via llvm-commits]

asbirlea marked an inline comment as done.
asbirlea added inline comments.


================
Comment at: llvm/trunk/lib/Analysis/AliasAnalysis.cpp:551
   ModRefInfo R = ModRefInfo::NoModRef;
+  bool MustAlias = true;
+  // Set flag only if no May found and all operands processed.
----------------
thakis wrote:
> You need IsMustAlias (or AllOperandsMustAlias or what have you) here too; as is this shadows the MustAlias AliasResult, and `AR != MustAlias` below on line 568 now compares with this bool instead of with the enum value as intended. (Are we missing test coverage here?)
> 
> (found by msvc warning 4805 which I had enabled locally for a bit.)
Should be fixed in r331222, thanks for the catch!
I'll look into expanding test coverage when starting to use the Must info.


Repository:
  rL LLVM

https://reviews.llvm.org/D38862