[PATCH] D46250: [AArch64][SVE] Asm: Support for LD1RQ load-and-replicate quad-word vector instructions.

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer accepted this revision.
SjoerdMeijer added a comment.
This revision is now accepted and ready to land.

Looks OK to me.



================
Comment at: test/MC/AArch64/SVE/ld1rqb-diagnostics.s:44
+
+ld1rqb z0.h, p0/z, [x0]
+// CHECK: [[@LINE-1]]:{{[0-9]+}}: error: invalid operand
----------------
Nit, and feel free to ignore: this "invalid operand" is a really useless error message because it doesn't tell you much (not related/cause by this patch of course). But at least the culprit should be indicated with the carrot symbol, something like this: 

  ld1rqb z0.h, p0/z, [x0]
         ^

Perhaps nice to match that too because it tells where the error is?


https://reviews.llvm.org/D46250