[PATCH] D45315: [X86] Improve unsigned saturation downconvert detection.

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 30 12:03:18 PDT 2018


RKSimon added inline comments.


================
Comment at: lib/Target/X86/X86ISelLowering.cpp:34651
+        Ops[1] = DAG.getConstant(C1, DL, In.getValueType());
+        return DAG.getNode(ISD::SMAX, DL, Ops[0].getValueType(), Ops);
+      }
----------------
Not sure what is going on here - why do you need to create a node - it looks like this is just smax again - and there shouldn't be a difference in value types at all?


Repository:
  rL LLVM

https://reviews.llvm.org/D45315





More information about the llvm-commits mailing list