[PATCH] D46276: [CostModel][X86] Derive TTI costs from complete scheduling models (PR36550) (RFC)
Simon Pilgrim via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 30 11:17:10 PDT 2018
RKSimon added inline comments.
================
Comment at: lib/Target/X86/X86TargetTransformInfo.cpp:658
+ static const SchedCostTblEntry AVX1CostTable[] = {
+ { ISD::FADD, MVT::v4f64, 2, { X86::VADDPDYrr } },
+ { ISD::FADD, MVT::v8f32, 2, { X86::VADDPSYrr } },
----------------
craig.topper wrote:
> craig.topper wrote:
> > Is this going to cause a bunch of SmallVectors to be constructed at startup? I think that goes against our coding standards.
> Or will it only happen the first time this function runs?
Thanks for reminding me - first time only but using SmallVector was a quick fix to get around ArrayRef not working properly after the first time for some reason that I didn't investigate thoroughly. IIRC moving the tables out of the functions and into global namespace fixed the issue.
Repository:
rL LLVM
https://reviews.llvm.org/D46276
More information about the llvm-commits
mailing list