[PATCH] D46209: [Support] Make JSON handle doubles and int64s losslessly

[Sam McCall via Phabricator via llvm-commits]

sammccall marked 2 inline comments as done.
sammccall added a comment.

Thanks for verifying this! (Still waiting for a decision on the master patch, I hope this doesn't block you too long!)



================
Comment at: unittests/Support/JSONTest.cpp:268
+          1.5 * double{0x8000000000000000},
+      },
+  };
----------------
simon_tatham wrote:
> You mentioned in D45753 that there might at some point be a need to handle `uint64_t` as well as `int64_t`. Given that, it might make sense to include some tests of negative integers now, so that if that does need to be added later, we'll catch any accidental breakage of the negative integer tests?
Done. I *really* hope we never have to support both at once!


Repository:
  rL LLVM

https://reviews.llvm.org/D46209