[PATCH] D45867: [InstCombine] Unfold masked merge with constant mask

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added inline comments.


================
Comment at: lib/Transforms/InstCombine/InstCombineAndOrXor.cpp:2433
                                           m_Value(D)),
                              m_Value(M))))))
     return nullptr;
----------------
I'm wondering if by simply capturing `M` here we miss some opportunities where
this first matched `M` does not satisfy any of these following checks (inverted/constant).

But i'm also not sure how to squeeze that into this one `match()`, in particular
i don't see how to know which of the matches is the real match, and which one is
stale pointer from the previous partial match.


Repository:
  rL LLVM

https://reviews.llvm.org/D45867