[PATCH] D46231: Move to new C++ binding interface that requires isl::quota annotations [RFC]

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur added a comment.

Could you add a paragraph about what (and) this is trying to accomplish into the summary? Even better, add documentation?

What's your plan to converge this to/with an official isl C++ binding?

Prepend the title with [Polly].

Virtual destructors are a quite heavy machinery. Are you sure it is worth adding/are there alternatives?

But I very much like the idea of fast-failing on out-of-quota! Should we generalize this to all kind of errors?



================
Comment at: lib/External/isl/include/isl/isl-noexceptions.h:62
+template<typename T>
+class quotaBase {
+public:
----------------
what's the code style here?


================
Comment at: lib/External/isl/include/isl/isl-noexceptions.h:106
 
+/* Indicate that when a quota-error occurs, that I did not yet think about
+ * this.
----------------
Who is "I"? The author of this line (i.e. @grosser)? I think what is meant is somebody who uses `quota_unclear` in their code, although it seems it is not meant to be used directly.


================
Comment at: lib/External/isl/isl_ctx.c:115
 	case ISL_ON_ERROR_CONTINUE:
+		fprintf(stderr, "%s:%d: %s\n", file, line, msg);
 		return;
----------------
Forgotten/leftover?


Repository:
  rPLO Polly

https://reviews.llvm.org/D46231