[PATCH] D46218: PR37275 packed attribute should not apply to base classes

Paul Robinson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 30 08:10:53 PDT 2018


probinson added a comment.

In https://reviews.llvm.org/D46218#1081933, @rjmccall wrote:

> I wonder if that was originally just an oversight that got turned into official policy.  Anyway, if it's the policy, it's what we have to do; LGTM.


I think it's actually correct behavior.  Why would an attribute on a derived class be allowed to alter the layout of a base class?  It would mean you can't convert Derived* to Base* safely.


Repository:
  rL LLVM

https://reviews.llvm.org/D46218





More information about the llvm-commits mailing list