[PATCH] D46249: [LLD][ELF][AArch64] Add missing LO12 relocation to usesOnlyLowPageBits
Peter Smith via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 30 01:51:07 PDT 2018
peter.smith created this revision.
peter.smith added reviewers: ruiu, espindola.
Herald added subscribers: kristof.beyls, arichardson, emaste, rengolin.
Herald added a reviewer: javed.absar.
The R_AARCH64_TLSLE_ADD_TPREL_LO12_NC relocation also only uses the low page bits, but is missing from the usesOnlyLowPageBits function. At present the usesOnlyLowPageBits function is not called for this relocation but I think it is worth adding for the completeness of usesOnlyLowPageBits.
https://reviews.llvm.org/D46249
Files:
ELF/Arch/AArch64.cpp
Index: ELF/Arch/AArch64.cpp
===================================================================
--- ELF/Arch/AArch64.cpp
+++ ELF/Arch/AArch64.cpp
@@ -140,6 +140,7 @@
case R_AARCH64_TLSDESC_ADD_LO12:
case R_AARCH64_TLSDESC_LD64_LO12:
case R_AARCH64_TLSIE_LD64_GOTTPREL_LO12_NC:
+ case R_AARCH64_TLSLE_ADD_TPREL_LO12_NC:
return true;
}
}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D46249.144513.patch
Type: text/x-patch
Size: 355 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180430/0b2da564/attachment.bin>
More information about the llvm-commits
mailing list