[PATCH] D46243: Move Schedule class to header file for allowing inheritance

Andrew Trick via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 30 00:53:22 PDT 2018


atrick added a comment.

These classes are not meant to be inherited from, and inheritance is generally terrible way to achieve code reuse across components. The principle behind the scheduling interfaces is to avoid implicit coupling between the target code and machine independent code.

Are you trying to create a new pass, separate from the pre-ra and post-ra schedulers? If so, what code do you need to reuse? scheduleRegions?


Repository:
  rL LLVM

https://reviews.llvm.org/D46243





More information about the llvm-commits mailing list