[PATCH] D45156: [MachineVerifier] Verify the RegUsageInfo collected for the current function.

[Jonas Paulsson via Phabricator via llvm-commits]

jonpa added inline comments.


================
Comment at: lib/CodeGen/MachineVerifier.cpp:360
+
+void MachineVerifier::verifyUsedPhysRegs(const MachineFunction &MF) {
+  // PhysicalRegisterUsageInfo becomes available with interprocedural
----------------
qcolombet wrote:
> I would have named it verifyPreservedMask or something.
> I would expect a verifyUsedPhysReg to work on UsedPhysRegMask not the PreservedMask one.
To me verifyPreservedMask mostly associates to getCallPreservedMask(), on the other hand :-)  How about verifyRegUsageInfoCollector() ?

BTW, is my naming for PreservedRegs good? It seems to be called just RegMask elsewhere. 'PreservedRegs' reflects the fact that if a bit is set, then that reg is preserved.  But this is always true for a RegMask, then perhaps we should stick to that name? Or 'FunctionRegMask'?



https://reviews.llvm.org/D45156