[PATCH] D46227: [islpp] Do not abuse isl::stat::error as early-abort

Tobias Grosser via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 28 11:14:35 PDT 2018


grosser created this revision.
Herald added subscribers: llvm-commits, mehdi_amini.
Herald added a reviewer: bollu.

isl::stat::error indicates a run-time error. We should not abuse it to
enforce an early abort of the foreach call. We should soon see a new
isl_*_every function family, which allows for specific return values to
abort early. When these are available, we should introduce these
deliberately to indicate early aborts.

In same cases we also abused these return values to indicate if a
certain value has been found or not. To avoid this abuse an extra
boolean is introduced to track this state.


Repository:
  rPLO Polly

https://reviews.llvm.org/D46227

Files:
  lib/Analysis/ScopInfo.cpp
  lib/Support/ISLTools.cpp
  lib/Transform/FlattenAlgo.cpp
  lib/Transform/ForwardOpTree.cpp
  lib/Transform/MaximalStaticExpansion.cpp
  lib/Transform/Simplify.cpp
  lib/Transform/ZoneAlgo.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D46227.144455.patch
Type: text/x-patch
Size: 8712 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180428/a4c22e7d/attachment.bin>


More information about the llvm-commits mailing list