[PATCH] D46207: Avoid some memory allocations in the ThreadPool

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 27 18:26:41 PDT 2018


dblaikie added inline comments.


================
Comment at: lib/Support/Parallel.cpp:94
 
-  void add(std::function<void()> F) override {
+  void add(std::function<void()> F, parallel::detail::Latch *L) override {
     std::unique_lock<std::mutex> Lock(Mutex);
----------------
This should probably take Latch by reference. I know lld has a bit of a different coding convention there - but it's not usually done that way in LLVM (well, it's perhaps a bit all over the shop, to be fair).


https://reviews.llvm.org/D46207





More information about the llvm-commits mailing list