[PATCH] D46217: [llvm-objcopy] Add --weaken option

[Jake Ehrlich via Phabricator via llvm-commits]

jakehehrlich added inline comments.


================
Comment at: tools/llvm-objcopy/llvm-objcopy.cpp:333-337
+      if ((!Config.SymbolsToWeaken.empty() &&
+           is_contained(Config.SymbolsToWeaken, Sym.Name) &&
+           Sym.Binding == STB_GLOBAL) ||
+          (Config.Weaken && Sym.Binding == STB_GLOBAL &&
+           Sym.NameIndex != STN_UNDEF))
----------------
Can you make this two separate if statements?


Repository:
  rL LLVM

https://reviews.llvm.org/D46217