[PATCH] D46216: [DAGCombiner] Set the right SDLoc on extended SETCC uses (5/N)

Vedant Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 27 15:21:50 PDT 2018


vsk created this revision.
vsk added reviewers: aprantl, niravd.

ExtendSetCCUses updates SETCC nodes which use a load (OriginalLoad) to
reflect a simplification to the load (ExtLoad).

Based on my reading, ExtendSetCCUses may create new nodes to extend a
constant attached to a SETCC. It also creates fresh SETCC nodes which
refer to its updated operands.

ISTM that the location applied to the new constant and SETCC nodes
created in ExtendSetCCUses should be the location of the ExtLoad.

This was suggested by Adrian in https://reviews.llvm.org/D45995.

Part of: llvm.org/PR37262


https://reviews.llvm.org/D46216

Files:
  lib/CodeGen/SelectionDAG/DAGCombiner.cpp
  test/CodeGen/X86/extend-set-cc-uses-dbg.ll
  test/CodeGen/X86/pr32284.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D46216.144410.patch
Type: text/x-patch
Size: 9529 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180427/f51a0cb2/attachment.bin>


More information about the llvm-commits mailing list