[PATCH] D45828: [PatternMatch] Stabilize the matching order of commutative matchers

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri updated this revision to Diff 144394.
lebedev.ri marked an inline comment as done.
lebedev.ri added a comment.

In https://reviews.llvm.org/D45828#1081483, @craig.topper wrote:

> I'd like to know more about why storing a reference didn't work.


Uhm, that makes two of us :/
I'm very sure it did not work back then when i initially tried, 
but now it just worked, and all the tests pass...

(i did check that there are tests for these commutative variants, even had to add some beforehand.)


Repository:
  rL LLVM

https://reviews.llvm.org/D45828

Files:
  include/llvm/IR/PatternMatch.h
  lib/Analysis/ValueTracking.cpp
  lib/Transforms/InstCombine/InstCombineAddSub.cpp
  lib/Transforms/InstCombine/InstCombineAndOrXor.cpp
  test/Transforms/InstCombine/and-or-not.ll
  test/Transforms/InstCombine/or-xor.ll
  unittests/IR/PatternMatch.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D45828.144394.patch
Type: text/x-patch
Size: 13910 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180427/835abc6d/attachment.bin>