[PATCH] D45571: [ELF] - Speedup MergeInputSection::splitStrings

[George Rimar via Phabricator via llvm-commits]

grimar added a comment.

In https://reviews.llvm.org/D45571#1081592, @espindola wrote:

> You have to update
>
>   lld :: ELF/compressed-debug-input.s                 
>   lld :: ELF/relocatable-compressed-input.s 
>   
>
> I guess you don't have zlib installed.


I'll check, thanks. zlib is generally not enabled/supported for windows LLVM configuration still, I believe.



================
Comment at: ELF/InputSection.cpp:892
+    if (!*Data)
+      return (S.size() - DataSize) | ((uint64_t)Hash << 32);
+    ++Data;
----------------
espindola wrote:
> It should be OK to return a std::pair, no?
I tried, but it affected the perfomance for me. I can probably add `Hash` reference out argument instead.


https://reviews.llvm.org/D45571