[PATCH] D45571: [ELF] - Speedup MergeInputSection::splitStrings

[Rafael Avila de Espindola via Phabricator via llvm-commits]

espindola added a comment.

I think this is fine. I will run the benchmarks locally to confirm.



================
Comment at: ELF/InputSection.cpp:892
+    if (!*Data)
+      return (S.size() - DataSize) | ((uint64_t)Hash << 32);
+    ++Data;
----------------
It should be OK to return a std::pair, no?


https://reviews.llvm.org/D45571