[PATCH] D45552: [NFC][LV][LoopUtil] Move LoopVectorizationLegality to Analysis tree

[Hideki Saito via Phabricator via llvm-commits]

hsaito added inline comments.


================
Comment at: include/llvm/Transforms/Vectorize/LoopVectorizationLegality.h:238
+  /// loop, only that it is legal to do so.
+  bool canVectorize(bool UseVPlanNativePath);
+
----------------
New parameter added.


================
Comment at: include/llvm/Transforms/Vectorize/LoopVectorizationLegality.h:325
+  /// checks are common for inner and outer loop vectorization.
+  bool canVectorizeLoopNestCFG(Loop *Lp, bool UseVPlanNativePath);
+
----------------
New parameter added.


================
Comment at: include/llvm/Transforms/Vectorize/LoopVectorizationLegality.h:329
+  /// (non-recursive) are considered legal for vectorization.
+  bool canVectorizeLoopCFG(Loop *Lp, bool UseVPlanNativePath);
+
----------------
New parameter added.


================
Comment at: lib/Transforms/Vectorize/LoopVectorizationLegality.cpp:890
+                                                    bool UseVPlanNativePath) {
+  assert((UseVPlanNativePath || Lp->empty()) &&
+         "VPlan-native path is not enabled.");
----------------
Assert kept here.


================
Comment at: lib/Transforms/Vectorize/LoopVectorizationLegality.cpp:998
+  if (!TheLoop->empty()) {
+    assert(UseVPlanNativePath && "VPlan-native path is not enabled.");
+
----------------
Assert kept here.


================
Comment at: lib/Transforms/Vectorize/LoopVectorize.cpp:4922
-bool LoopVectorizationLegality::canVectorizeLoopCFG(Loop *Lp) {
-  assert((EnableVPlanNativePath || Lp->empty()) &&
-         "VPlan-native path is not enabled.");
----------------
Assert Diego wants to keep.


================
Comment at: lib/Transforms/Vectorize/LoopVectorize.cpp:5029
-  if (!TheLoop->empty()) {
-    assert(EnableVPlanNativePath && "VPlan-native path is not enabled.");
-
----------------
Assert Diego wants to keep


https://reviews.llvm.org/D45552