[PATCH] D46034: Support for distributed ThinLTO options

[Rumeet Dhindsa via Phabricator via llvm-commits]

rdhindsa marked 3 inline comments as done.
rdhindsa added inline comments.


================
Comment at: lld/ELF/Driver.cpp:806
+      if (!Config->ThinLTOPrefixReplace.contains(';'))
+        error("thinlto-prefix-replace expects 'old;new' format");
+    } else if (!S.startswith("/") && !S.startswith("-fresolution=") &&
----------------
grimar wrote:
> Please provide the testcase for this error.
Added the testcase to thinlto_prefix_replace.ll


================
Comment at: lld/ELF/LTO.cpp:93
+  if (EC)
+    error("Failed to write " + NewModulePath + ".thinlto.bc" + ": " +
+          EC.message());
----------------
grimar wrote:
> Error messages start from the lower case usually.
> Also, the test would be nice to have if possible (i think you could create the file and so this code should error out when try to overwrite it, but I am not sure).
Added the test case to thinlto.ll 
By changing the permissions of the file, it is not available to write and test produces error.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D46034