[PATCH] D38862: Add must alias info to ModRefInfo.

[Nico Weber via Phabricator via llvm-commits]

thakis added a comment.
Herald added a subscriber: jlebar.
Herald added a reviewer: javed.absar.

A slightly late review comment:



================
Comment at: llvm/trunk/lib/Analysis/AliasAnalysis.cpp:551
   ModRefInfo R = ModRefInfo::NoModRef;
+  bool MustAlias = true;
+  // Set flag only if no May found and all operands processed.
----------------
You need IsMustAlias (or AllOperandsMustAlias or what have you) here too; as is this shadows the MustAlias AliasResult, and `AR != MustAlias` below on line 568 now compares with this bool instead of with the enum value as intended. (Are we missing test coverage here?)

(found by msvc warning 4805 which I had enabled locally for a bit.)


Repository:
  rL LLVM

https://reviews.llvm.org/D38862