[PATCH] D46034: Support for distributed ThinLTO options

[Rumeet Dhindsa via Phabricator via llvm-commits]

rdhindsa marked 8 inline comments as done.
rdhindsa added inline comments.


================
Comment at: lld/ELF/InputFiles.h:263
+  bool addedToLink();
+  bool isFileBitcode();
 
----------------
pcc wrote:
> I don't think you need this function. You should be able to use `isBitcode` to test whether `MB->File` is bitcode directly in the caller.
isBitcode is a static function in InputFiles.cpp. In order to be able to use that function in LTO.cpp : 
1) Either I move the function to InputFiles.h, in which case it will get imported to all other files including InputFiles.h ,which will increase code size.
In my opinion, we can simply call it for LazyObjFile. Please let me know if you still have concerns.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D46034