[PATCH] D46199: [SLPVectorizer] Debug intrinsics shouldn't affect spill cost

Hideki Saito via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 27 10:36:25 PDT 2018


hsaito added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:2559
+      if ((isa<CallInst>(&*PrevInstIt) &&
+           !isa<DbgInfoIntrinsic>(&*PrevInstIt)) &&
+          &*PrevInstIt != PrevInst) {
----------------
If LLVM doesn't have a generic "skip for cost" utility already, I think it's time to start having one. It's very likely that this goes beyond just DbgInfoIntrinsic and functionality would be common to many optimizers. If there is one, we should use that instead.



https://reviews.llvm.org/D46199





More information about the llvm-commits mailing list