[lld] r331045 - Do not set RequiresNullTerminator. NFC.

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 27 08:55:15 PDT 2018


Thanks!

Maybe add a comment saying what the false is?

Cheers,
Rafael

Rui Ueyama via llvm-commits <llvm-commits at lists.llvm.org> writes:

> Author: ruiu
> Date: Fri Apr 27 08:32:04 2018
> New Revision: 331045
>
> URL: http://llvm.org/viewvc/llvm-project?rev=331045&view=rev
> Log:
> Do not set RequiresNullTerminator. NFC.
>
> When reading object files, we don't need '\0' at end of each file.
>
> Modified:
>     lld/trunk/ELF/InputFiles.cpp
>
> Modified: lld/trunk/ELF/InputFiles.cpp
> URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/InputFiles.cpp?rev=331045&r1=331044&r2=331045&view=diff
> ==============================================================================
> --- lld/trunk/ELF/InputFiles.cpp (original)
> +++ lld/trunk/ELF/InputFiles.cpp Fri Apr 27 08:32:04 2018
> @@ -63,7 +63,7 @@ Optional<MemoryBufferRef> elf::readFile(
>  
>    log(Path);
>  
> -  auto MBOrErr = MemoryBuffer::getFile(Path);
> +  auto MBOrErr = MemoryBuffer::getFile(Path, -1, false);
>    if (auto EC = MBOrErr.getError()) {
>      error("cannot open " + Path + ": " + EC.message());
>      return None;
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits


More information about the llvm-commits mailing list