[PATCH] D46169: Split merge sections early

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 27 08:50:07 PDT 2018


grimar added a comment.

In https://reviews.llvm.org/D46169#1081164, @espindola wrote:

> In https://reviews.llvm.org/D46169#1080780, @grimar wrote:
>
> > I think it is probably OK. What about adding an assert checking that we do decompress only for non-alloc sections?
>
>
> I don't think an assert is appropriate as we would still do the right thing. If we do get to a point where we are decompressing too much we can revisit this.


Ok. We would hit this probably if would have compilers that implement the DWARF5 features about multiple debug sections like .debug_info liked with multiple text sections I think.
If those were compressed, calling decompress before marking live sections and dropping unused would be waste.
But there are no such compilers and everybody waiting for new standard afaik.


https://reviews.llvm.org/D46169





More information about the llvm-commits mailing list