[PATCH] D46177: [llvm-objcopy] Add --globalize-symbol option

[Alexander Shaposhnikov via Phabricator via llvm-commits]

alexshap added inline comments.


================
Comment at: tools/llvm-objcopy/llvm-objcopy.h:39
+template <class C, class T>
+auto contains(const C &Vector, const T &Elt)
+    -> decltype(std::end(Vector), true) {
----------------
it seems to me, that the name Vector is kind of misleading here - this function (as is) is more generic - maybe replace Vector with Sequence or Container ? + change Elt to smth like X (but that's just an opinion, not super important)


Repository:
  rL LLVM

https://reviews.llvm.org/D46177