[PATCH] D46120: [AArch64][SVE] Asm: Support for gather LD1/LDFF1 (vector + imm) load instructions.

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer accepted this revision.
SjoerdMeijer added a comment.
This revision is now accepted and ready to land.

Looks okay to me.



================
Comment at: lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp:533
+      MinVal = 0;
+      MaxVal = ((uint64_t(1) << Bits) - 1) * Scale;
+    }
----------------
int64_t?


================
Comment at: test/MC/AArch64/SVE/ld1sh-diagnostics.s:150
+
+ld1sh z0.s, p0/z, [z0.s, #64]
+// CHECK: [[@LINE-1]]:{{[0-9]+}}: error: index must be a multiple of 2 in range [0, 62].
----------------
Nit: feel free to ignore this, but I think I would also test -1 and 63 simply because they are the first values out of range (I appreciate they are not a multiple of 2, for which there are checks.) Same comment about other files below.


https://reviews.llvm.org/D46120