[PATCH] D46178: [SCEV] Reduce the number of invocation to non trivial getExact function

[Max Kazantsev via Phabricator via llvm-commits]

mkazantsev added a comment.

Please add more details commit message that `getExact` in this place is only used for statistics collection, and since it has side effects it cannot be eliminated even if the collection is disabled.

Code-wise, it should be fine, but I'm not sure if it is OK to use this define outside of statistic collection infrastructure. I don't see precedents. If there is no guideline against that then I'm fine with it.



================
Comment at: lib/Analysis/ScalarEvolution.cpp:6518
   }
+#endif
 
----------------
  #endif  // LLVM_ENABLE_STATS


https://reviews.llvm.org/D46178