[PATCH] D46157: [DAGCombiner] Factor out duplicated logic for an extload combine, NFC (3/N)

Vedant Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 26 17:12:24 PDT 2018


vsk created this revision.
vsk added reviewers: niravd, aprantl.

Part of the logic for combining (zext (load ...)) and (sext (load ...))
is duplicated. This creates problems because bugs in one version have to
be fixed again in the other version.

To address this, as a first step, I've extracted the duplicate logic
into a helper. I'll fix the debug location bug in the helper and
eliminate the copy of its logic in a followup.

Part of: llvm.org/PR37262


https://reviews.llvm.org/D46157

Files:
  lib/CodeGen/SelectionDAG/DAGCombiner.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D46157.144247.patch
Type: text/x-patch
Size: 5215 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180427/f85c9e57/attachment.bin>


More information about the llvm-commits mailing list