[PATCH] D45118: Linking debug (DWARF) sections from the WebAssembly object files

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added inline comments.


================
Comment at: wasm/InputChunks.h:28
 #include "llvm/Object/Wasm.h"
+#include "llvm/Support/LEB128.h"
 
----------------
No longer needed here?  maybe in the cpp file?


================
Comment at: wasm/InputFiles.cpp:139
+    if (auto *Sym = dyn_cast<DefinedSection>(getSectionSymbol(Reloc.Index))) {
+      const SymbolTable::InputFilesSectionsSet &SectionsSet =
+          Symtab->InputFilesSections[Sym->SectionIndex];
----------------
Maybe I'm missing something but SymbolTable seems like the wrong place to store this. 
What do you think about my last comments about how these symbols should be local and therefore not be added to symbol table at all?

Why can't you just replace this code with ?
```
InputSection* IS = CustomSectionsByIndex[Sym->SectionIndex];
return IS->OutputOffset + Reloc.Addend;
```

I'm probably missing something here.



Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D45118