[PATCH] D45995: [DAGCombiner] Set the right SDLoc on a newly-created zextload (1/N)

[Vedant Kumar via Phabricator via llvm-commits]

vsk added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:8032
 
       ExtendSetCCUses(SetCCs, N0, ExtLoad, SDLoc(N), ISD::ZERO_EXTEND);
       // If the load value is used only by N, replace it via CombineTo N.
----------------
vsk wrote:
> aprantl wrote:
> > Out of curiosity, why doesn't this also get the `SDLoc(N0)`?
> I'm not sure what SetCCUses are. It's possible that these need a different location. I can look into it as a follow-up.
Looking at this some more, it seems like applying SDLoc(ExtLoad) to the new SetCC nodes would make more sense.


https://reviews.llvm.org/D45995