[PATCH] D44965: [llvm][Instrumentation/MC] Add Call Graph Profile pass and object file emission.

[Michael Spencer via Phabricator via llvm-commits]

Bigcheese added a comment.

The MC and Object parts are enough for lld, yes.



================
Comment at: lib/CodeGen/TargetLoweringObjectFileImpl.cpp:147
+    const MCSymbol *From = Streamer.getContext().getOrCreateSymbol(
+        cast<MDString>(E->getOperand(0))->getString());
+    const MCSymbol *To = Streamer.getContext().getOrCreateSymbol(
----------------
espindola wrote:
> Should the metadata be referring to symbols by name?
Hmm, it may make more sense to refer to the symbols by `GlobalValue` instead, but that just delays the conversion to string.


https://reviews.llvm.org/D44965