[PATCH] D45558: [test-suite] Save stats for LTO step too.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 26 15:42:04 PDT 2018


fhahn added inline comments.


================
Comment at: test-suite/trunk/CMakeLists.txt:198
+  # Collect stats for LTO step too.
+  if (${CMAKE_C_FLAGS} MATCHES ".*-flto.*" AND
+      ${CMAKE_CXX_FLAGS} MATCHES ".*-flto.*")
----------------
MatzeB wrote:
> You could just append the flag to LDFLAHS unconditionally now, can you? (Or do nothing at all, I think currently we append cflags to all linker invocations too; which admittedly is bad style but unlikely to change...
Ah I saw your comment too late, sorry! I think the main reason I originally added it conditionally is to avoid "unused argument" warnings when not doing LTO. What do you think?


Repository:
  rL LLVM

https://reviews.llvm.org/D45558





More information about the llvm-commits mailing list