[PATCH] D46147: [NVPTX] Added a feature to use short pointers for const/local/shared AS.

[Justin Lebar via Phabricator via llvm-commits]

jlebar added a comment.

Ben, are you comfortable reviewing this?



================
Comment at: llvm/lib/Target/NVPTX/NVPTX.td:78
+def SHORTPTR : SubtargetFeature<"short-ptr", "UseShortPointers", "true",
+                                "Use short pointers for const/local/shared AS">;
+
----------------
Should we s/short/32-bit/, or do you want to leave open the possibility of using shorter pointers?


================
Comment at: llvm/lib/Target/NVPTX/NVPTXISelDAGToDAG.cpp:738
 
+  bool UseShortPointer = Subtarget->useShortPointers();
   if (DstAddrSpace == ADDRESS_SPACE_GENERIC) {
----------------
s/ShortPointer /ShortPointers /?

Same below.


https://reviews.llvm.org/D46147