[PATCH] D46133: [InstCombine, ARM, AArch64] Convert table lookup to shuffle vector

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: lib/Transforms/InstCombine/InstCombineCalls.cpp:951
+
+      if (auto GV = dyn_cast<GlobalVariable>(V)) {
+        if (GV->isConstant() && GV->hasDefinitiveInitializer()) {
----------------
Please use llvm::ConstantFoldLoadFromConstPtr.


================
Comment at: lib/Transforms/InstCombine/InstCombineCalls.cpp:974
+
+  // Check whether the mask matches the pattern { 7,6,5,4,3,2,1,0 }.
+  for (unsigned I = 0; I < NumElts; ++I) {
----------------
Why does the mask pattern matter?


https://reviews.llvm.org/D46133