[PATCH] D46103: Replace SharedSymbols with Defined when creating copy relocations

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.

LGTM

Nice! I actually once tried to do the same thing but didn't succeed. It's nice to see you made it!



================
Comment at: ELF/Relocations.cpp:464
 
+static void replaceWithDefined(Symbol &Sym, SectionBase *Sec, uint64_t Value,
+                               uint64_t Size) {
----------------
Please write a function comment to explain that a copy-relocated shared symbol is virtually the same as a defined symbol in a BSS section, so we replace the symbol as such.


https://reviews.llvm.org/D46103