[PATCH] D46103: Replace SharedSymbols with Defined when creating copy relocations

[Rafael Avila de Espindola via Phabricator via llvm-commits]

espindola added inline comments.


================
Comment at: ELF/Relocations.cpp:546
     Sym->IsUsedInRegularObj = true;
     Sym->Used = true;
   }
----------------
grimar wrote:
> Maybe inline `replaceWithDefined`? These 2 lines look a bit lonely here. I would either inline or move them to `replaceWithDefined`.
We need replaceWithDefined for copy relocations and canonical plt entries, so I don't think we should inline it.

While these two lines are only needed when handling alias to copy relocated entries, they probably don't cause an harm if moved to replaceWithDefined. I will experiment with that.


https://reviews.llvm.org/D46103