[PATCH] D45828: [PatternMatch] Stabilize the matching order of commutative matchers

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 26 09:02:17 PDT 2018


spatel added a comment.

In https://reviews.llvm.org/D45828#1079125, @lebedev.ri wrote:

> Ping. Would really like some feedback on this idea.


My implementation knowledge is limited, so I defer to other reviewers for the actual diffs.

Are the eval-order-stabilization changes independent of the new matcher?
How often does this come up? Ie, besides the proposed patch in https://reviews.llvm.org/D45664, can you use this on existing code to simplify it? If so, it might be worth including at least one of those changes here to show the value of adding a new matcher.


Repository:
  rL LLVM

https://reviews.llvm.org/D45828





More information about the llvm-commits mailing list