[PATCH] D46064: [llvm-objcopy] Add --localize-symbol option

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Aside from the conflict with https://reviews.llvm.org/D46029, mentioned already, and a couple of minor test-related points, this looks fine from my point of view.



================
Comment at: test/tools/llvm-objcopy/localize.test:31
+      Size:     8
+      Visibility: STV_HIDDEN
+  Weak:
----------------
Since the visibility isn't relevant to the test, you can get rid of this. I'd also rename all the symbols to be simpler named (i.e. something like "Local", "Weak" and "Global"). The default/hidden part was to do with the symbol visibility from the localize-hidden test (I assume?), to reflect which was which.


Repository:
  rL LLVM

https://reviews.llvm.org/D46064