[PATCH] D44905: [mips] Add support for Virtualization ASE

[Simon Dardis via Phabricator via llvm-commits]

sdardis added a comment.

LGTM, two minor nits that can be addressed on commit.



================
Comment at: lib/Target/Mips/MipsInstrFormats.td:236-237
   let Inst{15-11} = rd;
-  let Inst{10-3}  = 0;
+  let Inst{10-8} = guest;
+  let Inst{7-3}  = 0;
   let Inst{2-0}   = sel;
----------------
Nit: align the '=' here vertically.


================
Comment at: lib/Target/Mips/MipsInstrFormats.td:980
+  let Inst{31-26} = 0b010000;
+  let Inst{25} = 1;
+  let Inst{20-11} = code_;
----------------
Nit: align the '=' here vertically.


Repository:
  rL LLVM

https://reviews.llvm.org/D44905