[PATCH] D46106: [ARM] Codegen for v8.2A dot product intrinsics

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer accepted this revision.
SjoerdMeijer added a comment.
This revision is now accepted and ready to land.

Looks good to me.



================
Comment at: include/llvm/IR/IntrinsicsARM.td:720
 
+// v8.2-A dot product instructions
+class Neon_Dot_Intrinsic
----------------
Nit: Armv8.2-A?


================
Comment at: test/CodeGen/ARM/neon-dot-product.ll:3
+
+target datalayout = "e-m:e-p:32:32-i64:64-v128:64:128-a:0:32-n32-S64"
+target triple = "armv8-none-linux-gnu"
----------------
Nit: don't need this, or use the triple command line option?


Repository:
  rL LLVM

https://reviews.llvm.org/D46106