[PATCH] D46099: [ELF] Clarify help wording for --symbol-ordering-file

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 25 18:10:23 PDT 2018


smeenai created this revision.
smeenai added reviewers: espindola, grimar, jhenderson, ruiu.
Herald added subscribers: arichardson, emaste.

The input file for this option should contain a list of symbols, not a
list of sections, so it seems clearer to talk about laying out symbols
instead of sections. Referring to the file itself as the "symbol
ordering file" is consistent with --warn-symbol-ordering and less
ambiguous than "symbol file" (albeit slightly redundant).


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D46099

Files:
  ELF/Options.td


Index: ELF/Options.td
===================================================================
--- ELF/Options.td
+++ ELF/Options.td
@@ -291,7 +291,7 @@
 def strip_debug: F<"strip-debug">, HelpText<"Strip debugging information">;
 
 defm symbol_ordering_file: Eq<"symbol-ordering-file">,
-  HelpText<"Layout sections in the order specified by symbol file">;
+  HelpText<"Layout symbols in the order specified by symbol ordering file">;
 
 defm sysroot: Eq<"sysroot">, HelpText<"Set the system root">;
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D46099.144046.patch
Type: text/x-patch
Size: 498 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180426/04988ef5/attachment.bin>


More information about the llvm-commits mailing list